Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix release-merge workflow issues #2681

Merged
merged 2 commits into from
Sep 28, 2020
Merged

Fix release-merge workflow issues #2681

merged 2 commits into from
Sep 28, 2020

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Sep 25, 2020 •
edited
Loading

Description

It turns out set -e doesn't fail if the command uses !

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Added labels for change area (e.g. area/nodegroup), target version (e.g. version/0.12.0) and kind (e.g. kind/improvement)
  • Make sure the title of the PR is a good description that can go into the release notes

@michaelbeaumont michaelbeaumont added area/build-and-release skip-release-notes Causes PR not to show in release notes labels Sep 25, 2020
@michaelbeaumont michaelbeaumont changed the title Fix exit release-merge workflow if no diff Fix release-merge workflow issues Sep 25, 2020
@michaelbeaumont michaelbeaumont merged commit 625a540 into master Sep 28, 2020
@michaelbeaumont michaelbeaumont deleted the release-merge-fix2 branch September 28, 2020 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cPu1 cPu1 cPu1 approved these changes

Assignees
No one assigned
Labels
area/build-and-release skip-release-notes Causes PR not to show in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelbeaumont @cPu1