Skip to content

Commit

Permalink
Remove unnecessary allow-newer for async:hashable
Browse files Browse the repository at this point in the history
The reason for this workaround (simonmar/async#157)
has been fixed upstream and revised on Hackage.
  • Loading branch information
RyanGlScott committed Oct 26, 2024
1 parent 07ed35b commit 78caf61
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 11 deletions.
5 changes: 2 additions & 3 deletions .github/workflows/haskell-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ jobs:
compilerVersion: 9.8.2
setup-method: ghcup
allow-failure: false
- compiler: ghc-9.6.4
- compiler: ghc-9.6.6
compilerKind: ghc
compilerVersion: 9.6.4
compilerVersion: 9.6.6
setup-method: ghcup
allow-failure: false
- compiler: ghc-9.4.8
Expand Down Expand Up @@ -223,7 +223,6 @@ jobs:
if [ $((HCNUMVER >= 80200)) -ne 0 ] ; then echo "package lens-properties" >> cabal.project ; fi
if [ $((HCNUMVER >= 80200)) -ne 0 ] ; then echo " ghc-options: -Werror=missing-methods" >> cabal.project ; fi
cat >> cabal.project <<EOF
allow-newer: async-2.2.5:hashable
EOF
$HCPKG list --simple-output --names-only | perl -ne 'for (split /\s+/) { print "constraints: any.$_ installed\n" unless /^(lens|lens-examples|lens-properties)$/; }' >> cabal.project.local
cat cabal.project
Expand Down
5 changes: 0 additions & 5 deletions cabal.project
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
packages: .
./examples
./lens-properties

-- TODO: remove this when dependencies catch up
-- https://github.com/simonmar/async/issues/157
-- otherwise an old async-1.4 is picked
allow-newer: async-2.2.5:hashable
2 changes: 1 addition & 1 deletion examples/lens-examples.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ tested-with: GHC == 8.0.2
, GHC == 9.0.2
, GHC == 9.2.8
, GHC == 9.4.8
, GHC == 9.6.4
, GHC == 9.6.6
, GHC == 9.8.2
, GHC == 9.10.1

Expand Down
2 changes: 1 addition & 1 deletion lens-properties/lens-properties.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ tested-with: GHC == 8.0.2
, GHC == 9.0.2
, GHC == 9.2.8
, GHC == 9.4.8
, GHC == 9.6.4
, GHC == 9.6.6
, GHC == 9.8.2
, GHC == 9.10.1

Expand Down
2 changes: 1 addition & 1 deletion lens.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ tested-with: GHC == 8.0.2
, GHC == 9.0.2
, GHC == 9.2.8
, GHC == 9.4.8
, GHC == 9.6.4
, GHC == 9.6.6
, GHC == 9.8.2
, GHC == 9.10.1
synopsis: Lenses, Folds and Traversals
Expand Down

0 comments on commit 78caf61

Please sign in to comment.