tests: support python releases before 3.7 #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the "capture_output" parameter of subprocess.run() was introduced in python3.7. and subprocess.run() does not exist in python2. so should not rely on them unless we drop the support of python2 and python3.6 Signed-off-by: Kefu Chai <tchaikov@gmail.com>
as they are not widely used anymore in modern releases of popular distros. Signed-off-by: Kefu Chai <tchaikov@gmail.com>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the "capture_output" parameter of subprocess.run() was introduced in
python3.7. so should not rely on this feature unless we drop the support
of python2 and python3.6
Signed-off-by: Kefu Chai tchaikov@gmail.com