Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memo parsing #36

Closed
wants to merge 3 commits into from
Closed

Memo parsing #36

wants to merge 3 commits into from

Conversation

ejgallego
Copy link
Owner

No description provided.

Alizter
Alizter reviewed Jul 14, 2022
View reviewed changes
controller/memo.ml Outdated Show resolved Hide resolved
@ejgallego ejgallego force-pushed the memo_parsing branch 2 times, most recently from d3501e1 to bcb332e Compare September 26, 2022 16:45
@ejgallego ejgallego added this to the 0.1 milestone Oct 2, 2022
@ejgallego
[range] Add (unconditional) offset to points, fix bug in gt_range
7874e5d 
Offsets in positions are bound to stay due to ProseMirror and other
algorithms working much better with them.

We add them, add a resolution procedure for non-offset positions, and
fix a bug in gt_range.

The resolution method should use a smarter caching system.
@ejgallego
wip
338ca85
@ejgallego
wip
4509aba
@ejgallego ejgallego modified the milestones: 0.1.0, 0.1.1 Nov 16, 2022
@ejgallego ejgallego modified the milestones: 0.1.1, 0.2.0 Dec 8, 2022
@ejgallego ejgallego mentioned this pull request Dec 22, 2022
Closed
ejgallego added a commit that referenced this pull request Dec 22, 2022
@ejgallego
[fleche] Resume checking from common prefix on new version.
a5fcba9 
This does greatly reduce latency when editing deep down in a
document; closes #110 .

Also, kind of makes the need for parsing caching (#25, #36) moot, at
least with the current checking workflow.
@ejgallego ejgallego mentioned this pull request Dec 22, 2022
Merged
ejgallego added a commit that referenced this pull request Dec 26, 2022
@ejgallego
[fleche] Resume checking from common prefix on new version.
afe19ab 
This does greatly reduce latency when editing deep down in a
document; closes #110 .

Also, kind of makes the need for parsing caching (#25, #36) moot, at
least with the current checking workflow.
ejgallego added a commit that referenced this pull request Dec 26, 2022
@ejgallego
[fleche] Resume checking from common prefix on new version.
ad64782 
This does greatly reduce latency when editing deep down in a
document; closes #110 .

Also, kind of makes the need for parsing caching (#25, #36) moot, at
least with the current checking workflow.
ejgallego added a commit that referenced this pull request Dec 26, 2022
@ejgallego
[fleche] Resume checking from common prefix on new version.
d85df50 
This does greatly reduce latency when editing deep down in a
document; closes #110 .

Also, kind of makes the need for parsing caching (#25, #36) moot, at
least with the current checking workflow.
@ejgallego
Copy link
Owner Author

Now that we can resume correctly this doesn't seem to be too valuable, closing for now.

@ejgallego ejgallego closed this Jan 5, 2023
@ejgallego ejgallego deleted the memo_parsing branch January 5, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alizter Alizter Alizter left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ejgallego @Alizter