[check] Implement fileProgress notification for document progress
#106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a37a2df to
971b587
Compare
fileProgress notification for document progressfileProgress notification for document progress
5f6f3dd to
0c74173
Compare
Alizter
reviewed
Dec 23, 2022
Alizter
reviewed
Dec 23, 2022
Alizter
reviewed
Dec 23, 2022
Alizter
reviewed
Dec 23, 2022
Alizter
approved these changes
Dec 23, 2022
7f9a8c2 to
91f07ab
Compare
91f07ab to
bfed5ca
Compare
This was a silly mistake, `_end` is convention for unused. (I'm a bit "dislexic" with this stuff)
This is modelled after Lean's `$/lean/fileProgress` notification: a yellow bar in the right side panel indicates what parts of the document are still not checked. Fixes #54 Note that we send on fileProgress per sentence, that's likely too much; for now, we throttle the decoration update. Could be made into a user-config.
bfed5ca to
8ebe84b
Compare
ejgallego
added a commit
to ejgallego/opam-repository
that referenced
this pull request
Dec 27, 2022
CHANGES: ------------------------- - Don't crash if the log file can't be created (@ejgallego, ejgallego/coq-lsp#87) - Use LSP functions for client-side logging (@ejgallego, ejgallego/coq-lsp#87) - Log `_CoqProject` detection settings to client window (@ejgallego, ejgallego/coq-lsp#88) - Use plugin include paths from `_CoqProject` (@ejgallego, ejgallego/coq-lsp#88) - Support OCaml >= 4.12 (@ejgallego, ejgallego/coq-lsp#93) - Optimize the number of diagnostics sent in eager mode (@ejgallego, ejgallego/coq-lsp#104) - Improved syntax highlighting on VSCode client (@artagnon, ejgallego/coq-lsp#105) - Resume document checking from the point it was interrupted (@ejgallego, ejgallego/coq-lsp#95, ejgallego/coq-lsp#99) - Don't convert Coq "Info" messages such as "Foo is defined" to feedback by default; users willing to see them can set the corresponding option (@ejgallego, ejgallego/coq-lsp#113) - Send `$/coq/fileProgress` progress notifications from server, similarly to what Lean does; display them in Code's right gutter (@ejgallego, ejgallego/coq-lsp#106, fixes ejgallego/coq-lsp#54) - Show goals on click by default, allow users to configure the behavior to follow cursor in different ways (@ejgallego, ejgallego/coq-lsp#116, fixes ejgallego/coq-lsp#89) - Show file position in goal buffer, use collapsible elements for goal list (@ejgallego, ejgallego/coq-lsp#115, fixes ejgallego/coq-lsp#109) - Resume checking from common prefix on document update (@ejgallego, ejgallego/coq-lsp#111, fixes ejgallego/coq-lsp#110) - Only serve goals, hover, and symbols requests when the document has been sufficiently processed (@ejgallego, ejgallego/coq-lsp#120, fixes ejgallego/coq-lsp#100)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is modelled after Lean's
$/lean/fileProgressnotification: ayellow bar in the right side panel indicates what parts of the
document are still not checked.
Fixes #54
Note that we send on fileProgress per sentence, that's likely too
much; for now, we throttle the decoration update. Could be made into a
user-config.