-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: efficient current Dock item detection and improved window management #254
Conversation
72d4a3d
to
2bece81
Compare
64047ce
to
83f9fe8
Compare
Took a look, I think we can just store the previous app name string and only allow the hide action when it differs. I believe that is what happened previously. Can I push to this PR, or are you working on anything? |
You can push. You'll probably want to use DockObserver's |
I push some changes, Looks better now, But it seems like quick mouse movement doesn't trigger SwiftUI's |
I just sat down to work on this, did you already do it? The link goes to a different part of the code now, I can't find the TODO. |
I think it's all working on my end, what isn't working for you? |
Yes i did it |
- Improve clarity for mouse distance threshold logic - Prevent accidental duplicate window display during fast mouse movements
@ShlomoCode I have solved all issues.
I have played around with this, and I think it irons out all the issues we were dealing with. Please give it a test, and let me know what you think. I left some comments in the WindowDismissalContainer to explain this logic. I am opening this for review in light of this, great work to both of us! :) |
@ejbills Sounds good! I'll give it a spin and come back |
It seems that when there are several open apps adjacent to each other in the Dock, the issue still exists CleanShot.2024-09-03.at.21.27.27.mp4 |
This is the case of point 3 on this comment: #254 (comment)
The dead zone for cleaning up lingering windows is 800 px. If you move your mouse away while a window is lingering, it will hide after the distance is > 800. I actually think this is too large of an area, what do you think is a reasonable area for this? (You can play around with it on line 59 of |
I have tested this all day with no issues, I will be merging. Again, thanks a ton @ShlomoCode, this is a huge and very beneficial PR for DockDoor. Great work. |
Describe your changes
kAXSelectedChildrenChangedNotification
andkAXSelectedChildrenAttribute
) instead of calculating mouse position.Ported from #214.
Related issue number(s) and link(s)
closes #190
closes #19
closes #243
closes #30
closes #54
closes #212
closes #277
Checklist before requesting a review
Core Functionality Changes
If this PR modifies core functionality, please provide a brief description of the changes and their impact below:
Fixes some bugs, and significantly improves performance.