Add icon to ContactNamePair and remove redundant keys from Afform entity #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now name, label and icon will all be fetched from metadata.
| @@ -1,6 +1,4 @@ | |||
| <?php | |||
| return [ | |||
| 'entity' => 'ContactNamePair', | |||
There was a problem hiding this comment.
@colemanw is this not being required civi-version dependent? Or was it never required just copy & paste acquired?
There was a problem hiding this comment.
It depends on civicrm/civicrm-core#20283
There was a problem hiding this comment.
If you kept the 'entity' => 'ContactNamePair' line then the rest of this PR would work with previous versions of Afform.
There was a problem hiding this comment.
Hmm - maybe I'll just wait to cut it until I'm ready to make it 5.39 dependent - otherwise I'l forget this cleanup
|
Cool |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now name, label and icon will all be fetched from metadata.