Deprecate no return on activity get

It turns out that the area most causey of civicrm#18968
is activity get calls with no 'return' - which should be less that the contact.get
ones so trying to deprecate no-return

Civi/Test/Api3TestTrait.php

@@ -159,6 +159,7 @@ public function callAPISuccess($entity, $action, $params = [], $checkAgainst = N
     $params = array_merge([
       'version' => $this->_apiversion,
       'debug' => 1,
+      'return' => 'id',
     ],
       $params
     );

api/v3/Activity.php

@@ -298,7 +298,10 @@ function civicrm_api3_activity_get($params) {
     $options['return']['status_id'] = $options['return']['activity_date_time'] = 1;
     $params['return'] = array_keys($options['return']);
   }
-
+  if (!isset($params['return']) && !$options['is_count']) {
+    // https://github.com/civicrm/civicrm-core/pull/18968
+    CRM_Core_Error::deprecatedWarning('Not setting a return array is deprecated as it will fail on complex sites.');
+  }
   $activities = _civicrm_api3_basic_get(_civicrm_api3_get_BAO(__FUNCTION__), $params, FALSE, 'Activity', $sql);
   if ($options['is_count']) {
     return civicrm_api3_create_success($activities, $params, 'Activity', 'get');

phpunit.xml.dist

@@ -5,7 +5,7 @@
          convertNoticesToExceptions="true"
          convertWarningsToExceptions="true"
          processIsolation="false"
-         stopOnFailure="false"
+         stopOnFailure="true"
          stderr="true"
          beStrictAboutTestsThatDoNotTestAnything="false"
          bootstrap="tests/phpunit/CiviTest/bootstrap.php"