-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add fromdateiso8601 and todateiso8601 #379
feat: Add fromdateiso8601 and todateiso8601 #379
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for submitting a pull request. LGTM 👍
Oops, it seems that $ jq-1.7.1 fromdateiso8601
"2024-11-25T14:13:48.123Z"
jq: error (at <stdin>:2): date "2024-11-25T14:13:48.123Z" does not match format "%Y-%m-%dT%H:%M:%SZ"
$ java -jar jackson-jq-cli-1.1.1-20241125.141032-1.jar 'fromdateiso8601'
"2024-11-25T14:13:48.123Z"
1732544028 |
Lack of handling for fractional seconds is raised as a bug, not feature request in JQ, see jqlang/jq#2224 . So happy to reproduce the bug, if you want me to. |
Looks pretty simple to add: from the instant, call getNano and if the value is different than 0, throw exception. |
Support for built-in fromdateiso8601 and todateiso8601.
Based on PR #322, taking into account reviewer comments.
Fixes #321
@eiiches , FYI