Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: standalone binaries #267

Merged
merged 3 commits into from
Aug 26, 2024
Merged

docs: standalone binaries #267

merged 3 commits into from
Aug 26, 2024

Conversation

th7nder
Copy link
Contributor

@th7nder th7nder commented Aug 25, 2024 •
edited by jmg-duarte
Loading

Description

Fixes #266.

Basically thanks to removing dynamic dependency on RocksDB, all of the binaries should work on any Linux x86_64.
I compiled them locally and published to a bucket, added instructions.

@th7nder th7nder added devops documentation Improvements or additions to documentation labels Aug 25, 2024
@th7nder th7nder added this to the Phase 1 milestone Aug 25, 2024
@th7nder th7nder self-assigned this Aug 25, 2024
@th7nder th7nder changed the base branch from develop to chore/no-ref/24-08-2024-nix-update August 25, 2024 07:10
@th7nder th7nder force-pushed the chore/no-ref/24-08-2024-nix-update branch from f6b2fc3 to ad4d551 Compare August 25, 2024 09:03
@th7nder th7nder force-pushed the docs/266/standalone-binaries branch 2 times, most recently from 1b278a2 to d2a7b12 Compare August 25, 2024 09:49
@th7nder th7nder changed the base branch from chore/no-ref/24-08-2024-nix-update to develop August 25, 2024 09:50
@th7nder th7nder force-pushed the docs/266/standalone-binaries branch 2 times, most recently from 50e01d8 to 9724409 Compare August 25, 2024 10:22
@th7nder th7nder marked this pull request as ready for review August 25, 2024 10:24
@th7nder th7nder requested review from jmg-duarte and cernicc August 25, 2024 10:24
@th7nder th7nder added the ready for review Review is needed label Aug 25, 2024
@th7nder th7nder force-pushed the docs/266/standalone-binaries branch from 9724409 to 99305e5 Compare August 25, 2024 16:18
@th7nder th7nder added ready for review Review is needed and removed ready for review Review is needed labels Aug 26, 2024
jmg-duarte
jmg-duarte reviewed Aug 26, 2024
View reviewed changes
Copy link
Contributor

@jmg-duarte jmg-duarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about those PATH exports, asides from that 👌

docs/src/getting-started/local-testnet.md Show resolved Hide resolved
neutrinoks
neutrinoks suggested changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@neutrinoks neutrinoks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add one little explanatory sentence in the beginning of the new chapter 👍

@th7nder th7nder added ready for review Review is needed and removed ready for review Review is needed labels Aug 26, 2024
neutrinoks
neutrinoks approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@neutrinoks neutrinoks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jmg-duarte jmg-duarte force-pushed the docs/266/standalone-binaries branch from 2243f17 to 13cc294 Compare August 26, 2024 10:03
@jmg-duarte jmg-duarte removed the ready for review Review is needed label Aug 26, 2024
@jmg-duarte jmg-duarte added the ready for review Review is needed label Aug 26, 2024
@jmg-duarte jmg-duarte merged commit 286e0cd into develop Aug 26, 2024
4 checks passed
@jmg-duarte jmg-duarte deleted the docs/266/standalone-binaries branch August 26, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neutrinoks neutrinoks neutrinoks approved these changes

@jmg-duarte jmg-duarte jmg-duarte approved these changes

@cernicc cernicc Awaiting requested review from cernicc

Assignees

@th7nder th7nder

Labels
devops documentation Improvements or additions to documentation ready for review Review is needed
Projects
None yet
Milestone
Phase 1
Development

Successfully merging this pull request may close these issues.

docs: try to release standalone binaries
3 participants
@th7nder @jmg-duarte @neutrinoks