Fix labels length check

[vajexal]

• pass label instead of previous token to checkLabelLength
  method because lexer parses digits and unicode chars as different tokens

var_dump(
    (new EmailValidator())->isValid(sprintf('example@%s.com', str_repeat('a4t', 50)), new NoRFCWarningsValidation())
);

// true but domain part is invalid

• convert idn to ascii to check label length of unicode domains

var_dump(
    (new EmailValidator())->isValid(sprintf('example@%s.com', str_repeat('ъ', 60)), new NoRFCWarningsValidation())
);

// true but domain part is invalid

[egulias]

Hi @vajexal, thanks for your PR.
I've left some comment for you.

[egulias]

You are overriding the original $label from the parameters, please use another variable, i.e $asciiLabel.

[egulias]

You could remove the if and directly return return (bool) ($idnaInfo['errors'] | IDNA_ERROR_LABEL_TOO_LONG) , label has passed the length test already so testing again in line 422 wouldn't be needed.

[egulias]

Good job @vajexal ! Thanks for contributing.
I'll merge shortly.

[egulias]

@vajexal while porting to v3, why this should rise the warning? it is a 60 char label long

[vajexal]

because if we convert label to idn, it's length will be > 63

var_dump(idn_to_ascii(str_repeat('ъ', 60), IDNA_DEFAULT, INTL_IDNA_VARIANT_UTS46, $idnaInfo), $idnaInfo);
// bool(false)
// array(3) {
//   ["result"]=> string(66) "xn--z1aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
//   ["isTransitionalDifferent"]=> bool(false)
//   ["errors"]=> int(2)
// }

[egulias]

Merging in order to release v3. Can you answer the question anyway please?