Not properly handling special characters with restrictions

[brianfreytag]

There are certain special characters

"(),:;<>@[\]

that have special requirements.

The validator is currently allowing:

• brian,freytag@gmail.com
• bri[an]freytag@gmail.com

And other examples like those.

It is also saying things are invalid that are valid like:

• "brian,freytag"@gmail.com
• "brian freytag"@gmail.com
• "brian@freytag"@gmail.com
• brian\ freytag@gmail.com

There are a whole lot of RFC things that are coming through that should be blocked and it's blocking a lot of things that should be getting through.

[egulias]

Hi @brianfreytag thanks for pointing this out. I appreciate your help.
If you where able to provide a PR on the next invalid behaviours you find, I'd gladly merge them.
I'm working on this, hope to have it solved soon.

brian\freytag@gmail.com is invalid (http://tools.ietf.org/html/rfc5322#section-3.2.3), since you are not escaping anything. If you look at the test, there are both cases for valid with escaping and invalid without escaping.

[brianfreytag]

brian\freytag@gmail.com isn't valid, no... but my example is brian\{space}freytag@gmail.com, so I was escaping the space.

If I get a little more free time I will look at the library and provid a PR or two for this. Kinda swamped with moving into the house I just bought, so I can't make any promises right now.

[egulias]

I see, I missed the space. You are right then, and should be working. There
is an special method for the case.
I'll take a look tonight to correct it in this PR.
Don't worry, enjoy your new home.
El 01/09/2014 06:10, "Brian Freytag" notifications@github.com escribió:

brian\freytag@gmail.com isn't valid, no... but my example is brian{
space}freytag@gmail.com, so I was escaping the space.

If I get a little more free time I will look at the library and provid a
PR or two for this. Kinda swamped with moving into the house I just bought,
so I can't make any promises right now.

—
Reply to this email directly or view it on GitHub
#19 (comment)
.

[egulias]

@brianfreytag I've added your reported bugs as tests and are now being handled properly with the new release 1.2.2. Can you close this one?
If you find more problems please open a new one :)
Thanks for your patience!