Subsume should succeed even when the tuple is not present #487
+12
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #487 will degrade performances by 35.94%Comparing Summary
Benchmarks breakdown
|
| @@ -360,7 +360,7 @@ fn test_subsume_primitive() { | |||
| (subsume (one)) | |||
| "#, | |||
| ); | |||
| assert!(res.is_ok()); | |||
There was a problem hiding this comment.
Could you change comment above so it reflects the current state of the test? That subsuming primitives is not allowed.
| @@ -430,7 +430,7 @@ fn test_serialize_subsume_status() { | |||
| None, | |||
| egglog::SerializedNode::Function { | |||
| name: ("a").into(), | |||
| offset: 0, | |||
| offset: 1, | |||
There was a problem hiding this comment.
Why are there two a functions values now? They are equivalent right?
|
Woops sorry @yihozhang I realized my review comments had been pending for two weeks sitting here unpublished! Didn't mean to leave you hanging |
4820561 to
9684208
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsumes #478 and fixes #462