This repository has been archived by the owner on Dec 6, 2021. It is now read-only.
Fix issue with process object being clobbered #193
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue is similar to the one encountered in the below issue.
https://github.com/chentsulin/electron-react-boilerplate/pull/245/files
In my particular case I was depending on a package which was using readable-stream.
https://github.com/nodejs/readable-stream/blob/master/lib/_stream_writable.js#L53
In the above snippet, you can see
process.browser
andprocess.version
. When you define process in an object as was done previously it'll actually clobber all theprocess
object normalization that webpack does. This means that packages like readable-stream essentially become unusable.