fix: remove options.typescript support #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
==========================================
- Coverage 94.96% 94.88% -0.08%
==========================================
Files 12 12
Lines 596 587 -9
==========================================
- Hits 566 557 -9
Misses 30 30
Continue to review full report at Codecov.
|
popomore
reviewed
Apr 5, 2018
lib/format_options.js
Outdated
| @@ -42,9 +42,9 @@ module.exports = function formatOptions(options) { | |||
|
|
|||
| // typescript | |||
| if (!('typescript' in options)) { | |||
There was a problem hiding this comment.
我觉得这里可以改下，直接从 egg-bin 读取环境变量，不要传入 options 了
There was a problem hiding this comment.
也行，也就是 egg-bin test/cov 那边已经分析好了这段逻辑了，这里直接读取 env，我改改
whxaxes
reviewed
Apr 19, 2018
lib/format_options.js
Outdated
| } | ||
| } | ||
| } | ||
| options.typescript = String(process.env.EGG_TYPESCRIPT).toLowerCase() === 'true'; |
There was a problem hiding this comment.
不需要 toLowerCase 了吧？会设置这个环境变量的就只有 egg-bin，egg-bin 就是设置成了 true ，没必要再做一层兼容的处理把？
lib/format_options.js
Outdated
| } | ||
| } | ||
| } | ||
| options.typescript = String(process.env.EGG_TYPESCRIPT).toLowerCase() === 'true'; |
There was a problem hiding this comment.
如果 egg-core 改成读 env 的话，这一整段应该都不需要了，因为已经不需要传递 options 了
|
全部移除掉了，可以再看看 |
4 tasks
popomore
approved these changes
Apr 20, 2018
|
挂了？ |
|
fixed |
|
3.17.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change