feat: reload loggers after rotating #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 98.31% (diff: 100%)@@ master #5 diff @@
==========================================
Files 3 5 +2
Lines 111 119 +8
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 109 117 +8
Misses 2 2
Partials 0 0
|
|
+1 |
|
多进程覆盖率有问题 |
|
|
||
| module.exports = agent => { | ||
| // reload logger to new fd after rotating | ||
| agent.messenger.on('log-reload', () => { |
There was a problem hiding this comment.
挂在 agent 上的 logger 也需要 reload
1142bf1 to
be632c1
Compare
| // reload logger to new fd after rotating | ||
| agent.messenger.on('log-reload', () => { | ||
| agent.loggers.reload('got log-reload message'); | ||
| agent.loggers.coreLogger.info('[egg-logrotator] agent logger reload: got log-reload message'); |
|
哦。。这个mr相当于把egg reload的工作交给logrotator做了 |
|
嗯，logrotator 的功能是插件提供的，那么就应该插件完成。egg 不需要关注 logrotator 的逻辑。 |
| @@ -43,7 +43,7 @@ | |||
| "test-local": "egg-bin test", | |||
| "cov": "egg-bin cov", | |||
| "lint": "eslint --ext js --fix test app config *.js", | |||
| "ci": "npm run lint && npm run cov", | |||
| "ci": "echo $_ && npm run lint && DEBUG=coffee npm run cov", | |||
There was a problem hiding this comment.
那这里其他类库也要这样改么? 还有 egg-init 生成的骨架也要.
dbd88f9 to
a7cad3a
Compare
|
终于过了 |
| @@ -0,0 +1,9 @@ | |||
| 'use strict'; | |||
|
|
|||
| module.exports = app => { | |||
|
这个还没合？ |
|
这个没问题和掉了？ |
|
ping @fengmk2 |
|
+1 |
|
@popomore 发版本吧。 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change
将 egg 功能移过来，rotate 后重新 reload loggers