Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support no-override-exports #1

Merged
merged 2 commits into from
Feb 8, 2018
Merged

feat: support no-override-exports #1

merged 2 commits into from
Feb 8, 2018

Conversation

atian25
Copy link
Member

@atian25 atian25 commented Feb 7, 2018

no-override-exports

A common mistake that newbee will make - override module.exports and exports.

exports.view = {};

module.exports = appInfo => {
  const config = exports = {};
  config.keys = '123456';
  return config;
}

eggjs/egg#2088

@atian25 atian25 force-pushed the no-override-exports branch 6 times, most recently from 38552a0 to 866e5d2 Compare February 7, 2018 16:55
@atian25 atian25 force-pushed the no-override-exports branch from 866e5d2 to 6aa4465 Compare February 7, 2018 16:56
@codecov-io
Copy link

codecov-io commented Feb 8, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@0f4f3ac). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master     #1   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?      1           
  Lines             ?     31           
  Branches          ?      0           
=======================================
  Hits              ?     31           
  Misses            ?      0           
  Partials          ?      0
Impacted Files Coverage Δ
lib/rules/no-override-exports.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f4f3ac...f3028a4. Read the comment docs.

@atian25 atian25 merged commit c927923 into master Feb 8, 2018
@atian25 atian25 deleted the no-override-exports branch February 8, 2018 05:58
@atian25 atian25 mentioned this pull request Feb 11, 2018
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants