env_*: log command output #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two instances where we forget to check the output of a command when it fails. This commit ensures that we log STDOUT/STDERR in the same way that we do whenever we capture `CombinedOutput`. Specifically, this commit adds logging for the output when we fail to recursively chmod the shared directory as part of the cleanup process. One note here: recursively chmod-ing the shared directory could easily fail if a container saves a file as root and the CI user is not root. We might want to forget about chmod-ing and instead do a `rm -rf`, which will delete files not owned by the user executing the command. Signed-off-by: Lucas Servén Marín <lserven@gmail.com>
squat
added a commit
to wavyland/wavy
that referenced
this pull request
Sep 7, 2023
This commit ensures that the cleanup of the e2e tests is clean. It removes the capture.png file, which is not chmod-able to ensure the the cleanup of the Kind cluster does not fail. This is a workaround until a better solution, like the one mentioned in efficientgo/e2e#69 is available. Signed-off-by: Lucas Servén Marín <lserven@gmail.com>
saswatamcode
approved these changes
Sep 8, 2023
|
Yeah! It looks like the Mac tests can't pull Quay images, or so being able to pull after some time, but only with Kind! This could be some kind of ordering issue, since the Kind tests on Mac are going to be the ones that start the latest. |
bwplotka
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two instances where we forget to check the output of a command
when it fails. This commit ensures that we log STDOUT/STDERR in the same
way that we do whenever we capture
CombinedOutput. Specifically, thiscommit adds logging for the output when we fail to recursively chmod
the shared directory as part of the cleanup process.
One note here: recursively chmod-ing the shared directory could easily
fail if a container saves a file as root and the CI user is not root. We
might want to forget about chmod-ing and instead do a
rm -rf, whichwill delete files not owned by the user executing the command.
Signed-off-by: Lucas Servén Marín lserven@gmail.com