Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make edx aperture team owners of program-intent-engagement #173

Merged
merged 4 commits into from
Feb 21, 2025

Conversation

ilee2u
Copy link
Member

@ilee2u ilee2u commented Feb 20, 2025

JIRA: Link to JIRA ticket

Description: Cosmonauts is handing off ownership of this repo to the Aperture team. A .github/CODEOWNERS has been created to reflect this.

Merge checklist:

  • All reviewers approved
  • CI build is green
  • Changelog record added
  • Documentation updated (not only docstrings)

Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

@@ -18,7 +18,7 @@ jobs:
# optional parameters below; fill in if you'd like github or email notifications
# user_reviewers: ""
# team_reviewers: ""
email_address: "cosmonauts-requirements-update@2u-internal.opsgenie.net"
email_address: "aperture-requirements-update@2u-internal.opsgenie.net"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you verify this opsgenie email with aperture?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, let me ask them real quick.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be aperture@2u-internal.opsgenie.net.

@@ -0,0 +1 @@
* @openedx/2U-aperture
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line looks like it's causing an error, I think https://github.com/orgs/edx/teams/edx-aperture might be the right team

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see, I had copied this value from an openedx repo, so it looks like we need the edx value (i.e. the team under the edx org) instead.

@ilee2u ilee2u merged commit 0a9eaa9 into main Feb 21, 2025
5 checks passed
@ilee2u ilee2u deleted the ilee2u/add-aperture-as-CODEOWNERS branch February 21, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants