Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pull correct key from platform settings #33

Merged
merged 1 commit into from
Oct 29, 2021

Conversation

Tj-Tracy
Copy link
Contributor

@Tj-Tracy Tj-Tracy commented Oct 29, 2021

Description:
A typo was preventing the segment key from being properly taken from
settings.

Merge checklist:

  • Bump version
  • Add to changelog
  • Update docs (not only docstrings)

Post merge:
(Will eventually be handled via automation)

  • Release with new tag matching version

Author concerns: List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.

A typo was preventing the segment key from being properly taken from
settings.
@Tj-Tracy Tj-Tracy force-pushed the ttracy/MICROBA-1533-hotfix-key-setting-name branch from ca4315f to c077c65 Compare October 29, 2021 16:49
Copy link
Member

@justinhynes justinhynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Tj-Tracy Tj-Tracy merged commit c003507 into main Oct 29, 2021
@Tj-Tracy Tj-Tracy deleted the ttracy/MICROBA-1533-hotfix-key-setting-name branch October 29, 2021 17:05
@justinhynes
Copy link
Member

Looks like we standardized the use of SEGMENT_KEY as a configuration/setting name. So this should be good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants