fix: refactor useref code

edx · Oct 21, 2024 · f7f51e4 · f7f51e4
1 parent 05ce6b2
commit f7f51e4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/src/learning-header/New-AuthenticatedUserDropdown.jsx b/src/learning-header/New-AuthenticatedUserDropdown.jsx
@@ -59,10 +59,6 @@ const NewAuthenticatedUserDropdown = (props) => {
     careersMenuItem = '';
   }
 
-  // if (!isNewNotificationView) {
-  //   return null;
-  // }
-
   return (
     <Dropdown className="user-dropdown ml-3">
       <Dropdown.Toggle variant="outline-primary" id="user-dropdown">

diff --git a/src/new-notifications/NotificationTabs.jsx b/src/new-notifications/NotificationTabs.jsx
@@ -14,6 +14,7 @@ const NotificationTabs = () => {
   const {
     appName, handleActiveTab, tabsCount, appsId, updateNotificationData,
   } = useContext(notificationsContext);
+  const fetchNotificationsRef = useRef(null);
   const { fetchNotificationList, markNotificationsAsSeen } = useNotification();
 
   const fetchNotificationsList = useCallback(async () => {
@@ -25,8 +26,9 @@ const NotificationTabs = () => {
     }
   }, [appName, fetchNotificationList, updateNotificationData, markNotificationsAsSeen, tabsCount]);
 
-  const fetchNotificationsRef = useRef(fetchNotificationsList);
-  fetchNotificationsRef.current = fetchNotificationsList;
+  useEffect(() => {
+    fetchNotificationsRef.current = fetchNotificationsList;
+  }, [fetchNotificationsList]);
 
   useEffect(() => {
     const fetchNotifications = async () => {