This repository has been archived by the owner on Nov 12, 2023. It is now read-only.
[SE-1927, SE-1986] Upgrade pymongo and fix issues #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit upgrades the version of pymongo from 2.x to 3.x, removing usages to deprecated functions usage and fixing tests where necessary. This version of pymongo supports MongoDB 2.x all the way up to 4.2, and this ensures that the platform will be able to run on a supported MongoDB version in the next release. (cherry picked from commit 9b69d5a62684dc3d9d86b7e71081bebd432bd7d9)
itsjeyd
reviewed
Dec 5, 2019
There was a problem hiding this comment.
@pkulkark Thanks for reopening the previous PR on this fork :) The cherry-pick looks good. There's a bunch of failing tests -- not sure if (or to what extent) those are related to the changes being introduced here? I think we've run into issues getting tests to pass on this fork before. To get clarity maybe you could open another PR with some sort of trivial change and see how CircleCI builds behave there?
In any case, deploying the changes to stage for testing should be fine. Please see the comment that I will post shortly on SE-1927, though, for an additional note about coordinating pending stage deployments with @swalladge :)
09c6280 to
5198291
Compare
itsjeyd
reviewed
Dec 13, 2019
| count = items.count() | ||
| assets = list(items) | ||
| result = self.fs_files.find(query, **find_args) | ||
| # Set values if result of query is empty |
There was a problem hiding this comment.
@pkulkark Is this comment still needed?
There was a problem hiding this comment.
Oops missed it. thanks for catching it! I've removed it.
5198291 to
09205e7
Compare
09205e7 to
9d892bf
Compare
a074da5 to
97802b4
Compare
97802b4 to
1e56121
Compare
|
Notes for upcoming deployments:
Other than that there are no differences between the versions of edx-platform code that the edxapp and worker clusters are running on stage/prod. |
Patch ironwood capa problem
[SE-2326] Merge pull request openedx#23102 from edx/patch-ironwood-capa-problem
* Security patch for edit_chapter XSS lint issues (Studio) and library page Co-authored-by: pkulkark <pooja@opencraft.com>
* Fix forum image upload
fix: [CAM2-762] notification texts updated, dates updated.
chore: [translations] added change to he po file.
fix: [CAM2-762] added changes to popup configuration.
fix: [CAM2-762] added changes to popup configuration.
…date-text fix: [CAM2-762] added changes to popup notification text.
…e only in case of notification 'hide' button was pressed.
…date-text fix: [CAM2-762] added changes to popup notification url inside the text.
…up-lms feat: [CAM2-943] added notification popup to each page of lms.
…cation-css-updated
fix: [CAM2-943] added changes to css notification popup to each page of lms
feat: [CAM2-875] added custom maintenance page.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit upgrades the version of pymongo from 2.x to 3.x, removing usages to deprecated functions usage and fixing tests where necessary.
This version of pymongo supports MongoDB 2.x all the way up to 4.2, and this ensures that the platform will be able to run on a supported MongoDB version in the next release.
(cherry picked from commit 9b69d5a62684dc3d9d86b7e71081bebd432bd7d9)