Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix adding visibility file dates in the actions menu #39

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

johnvente
Copy link
Contributor

@johnvente johnvente commented Mar 11, 2024

Description

This PR adds the actions for setting visibility dates to the 'Actions' menu. When you right-click on a file/folder, you can see the buttons 'Set file visibility with date' and 'Remove date visibility', respectively. Now, they are available in the 'Actions' menu as well

BEFORE NOW

How to test it

  • Check this branchjv/fix-adding-buttons-to-actions-menu in the XBlock files manager
  1. use node 18
nvm use
  1. install dependencies
yarn install 

3 run to see any change in the react code

yarn dev 

Setting/Removing dates visibility

  1. Click on a file/folder then click on 'Actions' button on the Menu
    click-test

  2. You should see the options 'Set file visibility with date' and 'Remove date visibility'
    options-test

Merge checklist:
Check off if complete or not applicable:

  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

@johnvente johnvente force-pushed the jv/fix-adding-buttons-to-actions-menu branch from 076c64a to b542e58 Compare March 11, 2024 19:58
@johnvente johnvente merged commit c2fa71d into main Mar 11, 2024
4 checks passed
@johnvente johnvente deleted the jv/fix-adding-buttons-to-actions-menu branch March 11, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants