Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow to move files to unpublished folder #33

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

johnvente
Copy link
Contributor

Description

When we uploaded files inside a folder and then deleted them, an error occurred. Additionally, when the folders contained subfolders, the files were not moved to the unpublished folder. With this fix, the error disappears, and all files will be correctly moved to the unpublished folder.

BEFORE NOW

How to test it

  • Check this branch jv/fix-delete-folder-content in the XBlock files manager
  1. use node 18
nvm use
  1. install dependencies
yarn install 

3 run to see any change in the react code

yarn dev 

Merge checklist:
Check off if complete or not applicable:

  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

@johnvente johnvente requested a review from a team December 1, 2023 20:26
@Ian2012
Copy link
Contributor

Ian2012 commented Dec 1, 2023

@johnvente can you bump version and add a changelog entry?

Copy link
Contributor

@mariajgrimaldi mariajgrimaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working as expected!

  • Removing folders move the files to the unpublished folder
  • Removing a folder with folders moves the files to the unpublished folder

@johnvente johnvente merged commit 9bf526a into main Dec 1, 2023
@johnvente johnvente deleted the jv/fix-delete-folder-content branch December 1, 2023 20:43
@johnvente johnvente changed the title fix: allow to move files to unpublish folder fix: allow to move files to unpublished folder Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants