fix: use fileMap as source of truth for deleting folders #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34c29c3 to
a8eaae2
Compare
johnvente
reviewed
Nov 30, 2023
0e8c97d to
ef7abc2
Compare
(cherry picked from commit 2d58279)
ef7abc2 to
c660969
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue in which if a file already uploaded was moved to a folder, and this folder was deleted the file would disappear. It was caused because the
childrenis not the source of truth, but thechildrenIdsis, this PR uses thechildrenIdsto map the files and move it to the Unpublished folder