feat: allow to download multiple files and folders #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d76c7ca to
558c791
Compare
mariajgrimaldi
suggested changes
Nov 14, 2023
|
Remember adding (minimal) unittests for this new implementation |
|
@Ian2012: I tried it but it's not working for me. It stays polling the task status, do I need some setup done in my local environment? |
|
Also, can we add a message indicating that the download is in progress? So the user waits for it |
1d8fe9d to
441fb5c
Compare
0767301 to
fd14876
Compare
0b80fb3 to
fa9bdfe
Compare
test: adjust docstrings docs: fix indentation issues
fa9bdfe to
2b64b83
Compare
| for content in folder_structure: | ||
| if asset_key:=content.get("asset_key"): | ||
| file_content = contentstore().find(AssetKey.from_string(asset_key)) | ||
| ziph.writestr(zinfo_or_arcname=content["path"], data=file_content.data) |
There was a problem hiding this comment.
Suggested change
| ziph.writestr(zinfo_or_arcname=content["path"], data=file_content.data) | |
| ziph.writestr(zinfo_or_arcname=content["path"], data=file_content.data) | |
johnvente
reviewed
Nov 23, 2023
johnvente
reviewed
Nov 23, 2023
8512c51 to
cb53889
Compare
BryanttV
reviewed
Nov 24, 2023
4a869a4 to
01f54cc
Compare
01f54cc to
6f3ba4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows to download of multiple files in a zip file. It does so by creating a celery task with the contents to download, and it creates the zip file and uploads it to the default django storage. The task ID is returned so that the client can perform long pulling to verify the state of the task. Once the task status is
SUCCESS,the download URL is returned as part of the task result and the file is automatically downloaded for the client in a file calleddownload.zipThis implementation support folders and files.