-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sumac): add css support #21
feat(sumac): add css support #21
Conversation
@Asespinel the test are not passing due to a linter issue, could you have a look on it? (in your local environment you can run Looks like is a file you are not changing my sugest is unable the linter rule in that line. |
@dcoa Lint error issues were fixed. Currently, the errors presented in the PR are associated with the unit tests, to which we will not dedicate time to be able to close this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM... I would only call for publishing the new package versions in NPM, but it's not a blocking request
Description
This PR intends to add CSS Variables support to th Sumac release.
How to Test