Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sumac): add css support #21

Merged

Conversation

Asespinel
Copy link

@Asespinel Asespinel commented Jan 8, 2025

Description

This PR intends to add CSS Variables support to th Sumac release.

How to Test

  1. Create a Sumac environment you can use Tutor or TVM.
  2. Mount this MFE using this branch using tutor mounts add path/to/learning
  3. Run tutor config save
  4. Add this config to you development.py file or to your tenant settings:
MFE_CONFIG["PARAGON_THEME_URLS"] = {
    "core": {
        "url": "https://cdn.jsdelivr.net/npm/@openedx/paragon@$paragonVersion/dist/core.min.css"
    },
    "defaults": {
        "light": "light"
    },
    "variants": {
        "light": {
            "url": "https://cdn.jsdelivr.net/npm/@openedx/paragon@$paragonVersion/dist/light.min.css"
        }
    }
}

@Asespinel Asespinel changed the base branch from master to ednx-release/sumac.master January 8, 2025 01:12
@dcoa dcoa changed the title feat(sumac): add css support and cdn compatibility feat(sumac): add css support Jan 9, 2025
@dcoa
Copy link

dcoa commented Jan 9, 2025

@Asespinel the test are not passing due to a linter issue, could you have a look on it? (in your local environment you can run npm run lint)

Looks like is a file you are not changing my sugest is unable the linter rule in that line.

@magajh magajh requested a review from jignaciopm January 15, 2025 15:04
@jignaciopm
Copy link

jignaciopm commented Jan 15, 2025

@dcoa Lint error issues were fixed. Currently, the errors presented in the PR are associated with the unit tests, to which we will not dedicate time to be able to close this PR.

Copy link

@bra-i-am bra-i-am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... I would only call for publishing the new package versions in NPM, but it's not a blocking request

@Asespinel Asespinel merged commit 7e54d8f into ednx-release/sumac.master Jan 20, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants