-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jlc/add common plugin tests #42
base: master
Are you sure you want to change the base?
Conversation
ff081b7
to
df9cf0b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you split this in two different PRs, celery task and command and could you do a rebase over the branch https://github.com/eduNEXT/eox-nelp/tree/and/add_notifications_models to start with the implementation?
eox_nelp/settings/common.py
Outdated
settings.INSTALLED_APPS.append(COURSE_CREATOR_APP) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably this will be no necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whole block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it fails me if I do not register the task(in the worker). At the moment the notifications task file is not called or imported in a principal file. So celery couldn't start a not registered task.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's why I said that probably this is not necessary, for reference check this PR I didn't need this
d95402c
to
539c8a9
Compare
539c8a9
to
ba3dd23
Compare
Description
This PR has two principal functions.
Useful information to include:
Checklist for Merge