Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clean certificates client package #243

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

Ang-m4
Copy link
Contributor

@Ang-m4 Ang-m4 commented Feb 14, 2025

Description

This PR removes the unused certificates module from the deprecated api_clients package.

Changes

I just deleted the unused modules and test, all of the import updates to the new external_api_clients were already committed.

Testing:

As i just deleted unused modules, test are not needed.

@github-actions github-actions bot added test size/m m lines label labels Feb 14, 2025
@Ang-m4 Ang-m4 marked this pull request as ready for review February 14, 2025 18:40
@Ang-m4 Ang-m4 requested a review from johanseto February 14, 2025 18:40
@johanseto johanseto requested review from johanseto and removed request for johanseto February 17, 2025 16:25
Copy link
Collaborator

@andrey-canon andrey-canon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added size/l and removed size/m m lines label labels Feb 24, 2025
@Ang-m4 Ang-m4 changed the base branch from afg/pearson-rti-client-removal to master February 24, 2025 20:40
@Ang-m4 Ang-m4 changed the base branch from master to afg/pearson-rti-client-removal February 24, 2025 20:46
@Ang-m4 Ang-m4 force-pushed the afg/pearson-rti-client-removal branch from cf74890 to 3644cc9 Compare February 24, 2025 22:10
Base automatically changed from afg/pearson-rti-client-removal to master February 24, 2025 22:19
@Ang-m4 Ang-m4 force-pushed the afg/certificates-api-client-removal branch from eec6905 to 39987eb Compare February 24, 2025 22:47
@github-actions github-actions bot added size/xl and removed size/l labels Feb 24, 2025
Copy link

This PR exceeds the recommended size of 1000 lines. Check if you are NOT addressing multiple issues with one PR. If is not the case continue the review process.

@Ang-m4 Ang-m4 changed the base branch from master to afg/pearson-engine-api-client-removal February 24, 2025 22:48
Base automatically changed from afg/pearson-engine-api-client-removal to master February 25, 2025 21:44
@Ang-m4 Ang-m4 force-pushed the afg/certificates-api-client-removal branch from 39987eb to 27e6263 Compare February 25, 2025 21:51
@github-actions github-actions bot added size/l and removed size/xl labels Feb 25, 2025
@Ang-m4 Ang-m4 merged commit bb307f3 into master Feb 25, 2025
7 checks passed
@Ang-m4 Ang-m4 deleted the afg/certificates-api-client-removal branch February 25, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants