Ability to specify custom I2C address and display size #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using this module, i faced the exact same issue as this one here. Until now it was not possible to to change the I2C address or the Bus-ID, because they were simply hard coded. Especially when you work with multiple displays or use Dev-Boards, witch has multiple I2C-Ports, this is a bit annoying. Yes, i understand the thought having only one selector for user friendliness. Because the user can simply choose the corresponding IC, and need not to figure out witch port to use or on witch address the IC is listening on.
So i don´t removed it.
Another thing that i noticed is, that there seems to be variables, witch already defines display sizes, but only one size (20x4) is specified in the size selector. I took the opportunity to simply add an option for the smaller 16x2 displays.
Finlay what i did here is:
Custom Addressoption to thevariantselectorHope this contribution helps. Please feel free to contact me if i missed anything or if you have some improvements.