Unify data fetching pt. 1: Type the models, clean the code #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
81978a9 to
50eada7
Compare
50eada7 to
1f025e2
Compare
serugeneris
approved these changes
Jul 24, 2024
antipitagoricamente
pushed a commit
that referenced
this pull request
Feb 16, 2025
Unify data fetching pt. 1: Type the models, clean the code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agarré todos los lugares donde había un fetch(), tipé todo, agregué manejos de estado tipo "cargando" o "error" que no estaban siendo contemplados. También eliminé un loader que veníamos llamando que la verdad es que no había nada útil, sólo hacía llamadas HTTP que no aportaban nada y agregaban código que encima era poco performante. Lo quemé con fuego.
La idea de este PR era unificar los llamados a datos, pero lo dejo hasta acá para seguir en un segundo PR así no se hace tan difícil de revisar.