-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple API endpoints use HTTP instead of HTTPS #81
Comments
Ah! This is because the memento URLs used to redirect from I’m also happy to accept a PR if you’d like to make the change. |
Mr0grog
added a commit
that referenced
this issue
Oct 29, 2022
We used to use HTTP (unsecure) for all archive.org URLs because requesting HTTPS used to redirect to HTTP (making HTTPS kind of a waste). That's no longer the case, and using HTTPS is always a good idea (even if you aren't sending secure info, it helps make sure you are getting legitimate data from the server you expect). Thanks to @sundhaug92 for pointing this out. Fixes #81.
Mr0grog
added a commit
that referenced
this issue
Oct 31, 2022
We used to use HTTP (unsecure) for all archive.org URLs because requesting HTTPS used to redirect to HTTP (making HTTPS kind of a waste). That's no longer the case, and using HTTPS is always a good idea (even if you aren't sending secure info, it helps make sure you are getting legitimate data from the server you expect). Thanks to @sundhaug92 for pointing this out. Fixes #81.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Ex:
wayback/wayback/_models.py
Line 253 in 024a80e
wayback/wayback/_client.py
Line 48 in 024a80e
wayback/wayback/_client.py
Line 58 in 024a80e
Note: Fixing this may require changing the mocks
The text was updated successfully, but these errors were encountered: