Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EdgeX 3.0] Device Profile model improvement #770

Closed
cloudxxx8 opened this issue Nov 30, 2022 · 3 comments · Fixed by #804 or #809
Closed

[EdgeX 3.0] Device Profile model improvement #770

cloudxxx8 opened this issue Nov 30, 2022 · 3 comments · Fixed by #804 or #809
Assignees
@chr1shung
Labels
enhancement New feature or request

Comments

@cloudxxx8
Copy link
Member

🚀 Feature Request

Relevant Package [REQUIRED]

This feature request is for core-metadata

Description [REQUIRED]

This is issue is opened for discussing the Device Profile model improvment in v3.0.

Describe the solution you'd like

The first suggestion is that Value Properties base, offset, scale etc become numerics rather than strings
@cloudxxx8 cloudxxx8 added the enhancement New feature or request label Nov 30, 2022
@cloudxxx8 cloudxxx8 moved this to New Issues in Technical WG Nov 30, 2022
@cloudxxx8 cloudxxx8 moved this from New Issues to Release Backlog in Technical WG Dec 7, 2022
@cloudxxx8
Copy link
Member Author

cloudxxx8 commented Jan 17, 2023 •
edited
Loading

To make the Device Resource more extendable, add an key/value map field called Others in the resourceProperties
https://github.com/edgexfoundry/go-mod-core-contracts/blob/f7989db8b92082d898b6a1da7af729e2e019421a/models/resourceproperties.go

@cloudxxx8 cloudxxx8 mentioned this issue Jan 27, 2023
Closed
@cloudxxx8 cloudxxx8 mentioned this issue Feb 6, 2023
Closed
@cloudxxx8 cloudxxx8 assigned judehung and chr1shung and unassigned judehung Feb 8, 2023
@chr1shung chr1shung mentioned this issue Feb 18, 2023
Merged
5 tasks
@github-project-automation github-project-automation bot moved this from Release Backlog to Minnesota Done in Technical WG Feb 21, 2023
@cloudxxx8 cloudxxx8 reopened this Feb 22, 2023
@github-project-automation github-project-automation bot moved this from Minnesota Done to New Issues in Technical WG Feb 22, 2023
@cloudxxx8 cloudxxx8 moved this from New Issues to Release Backlog in Technical WG Feb 22, 2023
@cloudxxx8
Copy link
Member Author

Discussed in Core WG meeting on 21 Feb 2023. We should rename Others to Optional for the consistency with the message broker settings.
Furthermore, this issue should cover that Value Properties base, offset, scale etc become numerics rather than strings as the description of this issue.

@cloudxxx8 cloudxxx8 assigned FelixTing and chr1shung and unassigned chr1shung and FelixTing Feb 22, 2023
@chr1shung chr1shung mentioned this issue Feb 22, 2023
Merged
5 tasks
@cloudxxx8 cloudxxx8 moved this from Release Backlog to QA/Code Review in Technical WG Mar 1, 2023
@github-project-automation github-project-automation bot moved this from QA/Code Review to Minnesota Done in Technical WG Mar 9, 2023
This was referenced Mar 9, 2023
Merged
Merged
Merged
@cloudxxx8
Copy link
Member Author

@iain-anderson should we also modify min and max to float64?

This was referenced Mar 15, 2023
Closed
Closed
weichou1229 pushed a commit to weichou1229/device-sdk-go that referenced this issue Mar 20, 2023
@weichou1229
refactor!: update data types in ResourceProperties
0e6ff39 
BREAKING CHANGE: support mask,shift,base,scale,offset in numeric data type

related to edgexfoundry/go-mod-core-contracts#770

Signed-off-by: Chris Hung <chris@iotechsys.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chr1shung chr1shung

Labels
enhancement New feature or request
Projects
Technical WG
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add 'Others' field in ResourceProperties
feat!: update data type in ResourceProperties
4 participants
@cloudxxx8 @chr1shung @judehung @FelixTing