Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added DATABASE_HOST env variable #456

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

cloudxxx8
Copy link
Member

@cloudxxx8 cloudxxx8 commented Aug 26, 2024

Added DATABASE_HOST env var in response to private config changes. Remove the obsoleted version in the compose file as well.

Close #455

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-compose/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

Added DATABASE_HOST env var in response to private config changes.
Remove the obsoleted `version` in the compose file as well.

Close edgexfoundry#455

Signed-off-by: Cloud Tsai <cloudxxx8@gmail.com>
Copy link
Contributor

@lindseysimple lindseysimple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit 08e453d into edgexfoundry:main Aug 26, 2024
3 checks passed
@cloudxxx8 cloudxxx8 deleted the issue-455 branch August 26, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update compose file for database configuration in private config file
2 participants