Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service-mesh: test readiness with exec probe #1142

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

burgerdev
Copy link
Contributor

@burgerdev burgerdev commented Jan 13, 2025

The startup probe for the mesh proxy is redirected onto the same port, causing Envoy to open connections to itself recursively. Unfortunately, this is not visible in the Envoy logs - I only discovered this condition while working on a custom proxy implementation.

Things that are still unclear:

  • There is some race condition that causes the redirection loop to only occur ~50% of the time.
  • Switching on debug logging makes this condition much rarer.
  • Exempting the TPROXY ports with iptables should make the SO_ORIGINAL_DST lookup fail, but the loop happens nonetheless.
  • The issue reproduces with opening and holding a single connection, while opening another, but not with just one connection.

Tests:

service-mesh/main.go Show resolved Hide resolved
packages/containers.nix Show resolved Hide resolved
internal/kuberesource/parts.go Show resolved Hide resolved
@katexochen katexochen added this to the v1.3.0 milestone Jan 13, 2025
Copy link
Member

@3u13r 3u13r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@burgerdev burgerdev merged commit fe915e3 into main Jan 13, 2025
42 of 44 checks passed
@burgerdev burgerdev deleted the burgerdev/mesh-probe branch January 13, 2025 13:40
@edgelessci
Copy link
Contributor

Successfully created backport PR for release/v1.2:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release/v1.2 bug fix Fixing a user facing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants