Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add build option #1

Merged
merged 9 commits into from
Feb 19, 2025
Merged

feat: add build option #1

merged 9 commits into from
Feb 19, 2025

Conversation

NicolasGirardot
Copy link
Collaborator

@NicolasGirardot NicolasGirardot commented Feb 19, 2025 •
edited by alexcasalboni
Loading

Checklist

  • I have read the Contributor Guide
  • I have read and agree to the Code of Conduct
  • I have added a description of my changes and why I'd like them included in the section below

Description of Changes

Describe your changes here

Related Issues

List related issues here

alexcasalboni
alexcasalboni approved these changes Feb 19, 2025
View reviewed changes
Copy link

@alexcasalboni alexcasalboni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 only a minor doubt about what happens when using true instead of "true"

@NicolasGirardot NicolasGirardot merged commit 6a671bd into main Feb 19, 2025
2 checks passed
@alexcasalboni alexcasalboni deleted the add-build-option branch February 19, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcasalboni alexcasalboni alexcasalboni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NicolasGirardot @alexcasalboni