Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement User Data Persistence with Encrypted Cookie #155

Conversation

SachaMorard
Copy link
Contributor

@SachaMorard SachaMorard commented Dec 20, 2024

Checklist

  • I have read the Contributor Guide
  • I have read and agree to the Code of Conduct
  • I have added a description of my changes and why I'd like them included in the section below

Description of Changes

We need to implement user data persistence through an encrypted cookie (edgee_u) to maintain user context across sessions. When a user event is fired, the user data should be stored in an encrypted cookie, and this data should be retrieved and added to the user context for subsequent events.

This PR follows the requirements and technical details of #154

I improved the documentation at the same time, which was not up to date in the scripts I worked on.

Related Issues

#154

@SachaMorard SachaMorard force-pushed the eoss-47-implement-user-data-persistence-with-encrypted-cookie branch from bdca0ec to 03a830f Compare December 20, 2024 07:24
@SachaMorard SachaMorard force-pushed the eoss-47-implement-user-data-persistence-with-encrypted-cookie branch from 03a830f to 4a4dcc5 Compare December 20, 2024 07:26
Copy link
Contributor

@CLEMENTINATOR CLEMENTINATOR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Copy link
Contributor

@alexcasalboni alexcasalboni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! at some point in the future, it'd be interesting to check/measure the performance impact of encrypt/decrypt on the compute time

@SachaMorard SachaMorard merged commit 65272d1 into main Dec 20, 2024
4 checks passed
@SachaMorard SachaMorard deleted the eoss-47-implement-user-data-persistence-with-encrypted-cookie branch December 20, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants