Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make zone in subnet optional #921

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

fix: make zone in subnet optional #921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/resources/cluster.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1340,7 +1340,7 @@ The following arguments are supported:
- `name` - (Required) - String - Name is the name of the subnet.
- `cidr` - (Optional) - (Computed) - String - CIDR is the IPv4 CIDR block assigned to the subnet.
- `ipv6_cidr` - (Optional) - String - IPv6CIDR is the IPv6 CIDR block assigned to the subnet.
- `zone` - (Required) - String - Zone is the zone the subnet is in, set for subnets that are zonally scoped.
- `zone` - (Optional) - String - Zone is the zone the subnet is in, set for subnets that are zonally scoped.
- `region` - (Optional) - String - Region is the region the subnet is in, set for subnets that are regionally scoped.
- `id` - (Optional) - String - ID is the cloud provider ID for the objects associated with the zone (the subnet on AWS).
- `egress` - (Optional) - String - Egress defines the method of traffic egress for this subnet.
Expand Down
2 changes: 1 addition & 1 deletion hack/gen-tf-code/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ func main() {
required("Name"),
),
generate(kops.ClusterSubnetSpec{},
required("Name", "Type", "Zone"),
required("Name", "Type"),
computed("CIDR"),
),
generate(kops.TopologySpec{},
Expand Down
2 changes: 1 addition & 1 deletion pkg/schemas/kops/Resource_ClusterSubnetSpec.generated.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ func ResourceClusterSubnetSpec() *schema.Resource {
"name": RequiredString(),
"cidr": OptionalComputedString(),
"ipv6_cidr": OptionalString(),
"zone": RequiredString(),
"zone": OptionalString(),
"region": OptionalString(),
"id": OptionalString(),
"egress": OptionalString(),
Expand Down