Skip to content

Commit

Permalink
Rollup merge of rust-lang#37503 - nwin:patch-3, r=steveklabnik
Browse files Browse the repository at this point in the history
Remove remark about poor code style

The current wording [seems to be confusing](https://www.reddit.com/r/rust/comments/5aat03/why_is_implementing_traits_on_primitive_types/). As an explanation when and why this could be considered as poor style would go beyond of the scope of this chapter I suggest to remove this remark.
  • Loading branch information
eddyb authored Nov 11, 2016
2 parents ff9dad0 + 5cf07f1 commit ae0c1fd
Showing 1 changed file with 8 additions and 14 deletions.
22 changes: 8 additions & 14 deletions src/doc/book/traits.md
Original file line number Diff line number Diff line change
Expand Up @@ -243,28 +243,22 @@ to know more about [operator traits][operators-and-overloading].
# Rules for implementing traits

So far, we’ve only added trait implementations to structs, but you can
implement a trait for any type. So technically, we _could_ implement `HasArea`
for `i32`:
implement a trait for any type such as `f32`:

```rust
trait HasArea {
fn area(&self) -> f64;
trait ApproxEqual {
fn approx_equal(&self, other: &Self) -> bool;
}

impl HasArea for i32 {
fn area(&self) -> f64 {
println!("this is silly");

*self as f64
impl ApproxEqual for f32 {
fn approx_equal(&self, other: &Self) -> bool {
// Appropriate for `self` and `other` being close to 1.0.
(self - other).abs() <= ::std::f32::EPSILON
}
}

5.area();
println!("{}", 1.0.approx_equal(&1.00000001));
```

It is considered poor style to implement methods on such primitive types, even
though it is possible.

This may seem like the Wild West, but there are two restrictions around
implementing traits that prevent this from getting out of hand. The first is
that if the trait isn’t defined in your scope, it doesn’t apply. Here’s an
Expand Down

0 comments on commit ae0c1fd

Please sign in to comment.