Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility fixes for Redmine 2.0 #1

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

rkallensee
Copy link

I made a few quick fixes to get the plugin working on Redmine 2.0. I updated the documentation and while I was at it I added the German translation.

@thimios
Copy link

thimios commented Nov 9, 2013

I use Redmine 2.3.3.stable.12240 and the latest code from https://github.com/rkallensee/redmine-google-analytics-plugin

I get a 404 when opening /settings/plugin/google_analytics_plugin

Here is what I see in the redmine log:

Started GET "/settings/plugin/google_analytics_plugin" for 78.52.17.72 at 2013-11-09 13:57:17 +0100
Processing by SettingsController#plugin as HTML
Parameters: {"id"=>"google_analytics_plugin"}
Current user: thimios (id=1)
Rendered settings/plugin.html.erb within layouts/admin (2.4ms)
Missing template, responding with 404
Rendered common/error.html.erb within layouts/base (0.2ms)
Rendered plugins/redmine_code_review/app/views/code_review/_html_header.html.erb (0.0ms)
Rendered plugins/redmine_code_review/app/views/code_review/_body_bottom.html.erb (0.0ms)
Completed 404 Not Found in 31ms (Views: 19.2ms | ActiveRecord: 3.0ms)

any ideas? Thanks!

@timc3
Copy link

timc3 commented Jan 2, 2014

The template is name incorrectly I think, in app/views/settings it should be _google_analytics_settings.html.erb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants