Update React to v17 #45
Conversation
- Adds support for `when` contexts in submenus - Adds support for treating menu contributions as toolbar contributions - Adds support for custom execution of commands based on menu context
The commit updates the monaco tokenization with the following improvements for performance: - skip tokenizations for lines exceeding the limit. - return partial tokenizations for line which take too long to tokenize. The fix ultimately resolves an issue which prevented large files from being opened and the application hanging. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
Adapted signature code so that the activeParameter is the one of the SignatureInformation if set. Signed-off-by: Jan Bicker <jan.bicker@typefox.io>
The commit updates the rendering of the problems-widget to more closely align with vscode: - removes `owner` from being displayed (only displays `source`). - updates the line and column number to align with vscode. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
The commit adds support for `title` in the `QuickPickOption` VS Code API. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
The commit updates the `caption` for `ViewContainer` to align with the behavior with vscode and also resolve and issue where we displayed odd titles. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
The commit updates additional builtins to use their proper `id` so they are not re-downloaded. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
The commit includes the following updates: - adds a `New File` toolbar item to replace the entry under the more context-menu. - adds a `New Folder` toolbar item to replace the entry under the more context-menu. - renamed `CommonCommands.NEW_FILE` to `CommonCommands.NEW_UNTITLED_FILE`. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com> Co-authored-by: yiliang114 <1204183885@qq.com>
There was a problem hiding this comment.
Looks good in general. Please add the "contributed on behalf" messages to the commit message as well as the changelog. Also a small entry in the migration guide is needed. However the update to React 17 should not be of great impact (link to some React 17 release guide)
|
@sgraband please run locally and verify whether everything works (i.e. the build and intellisense within VS Code) and there are no warnings or errors in the logs |
|
Apart from the Not sure if we can do something against the failing license check. Could you check this? |
|
The license check is complaining about
@AlexandraBuzila can you try adding this? |
* update react and react-dom to version 17.0.0 * fix return type in ToolbarImpl.renderGroupsInColumn Contributed on behalf of STMicroelectronics Signed-off-by: Alexandra Buzila <abuzila@eclipsesource.com>
2ac882c to
06cc199
Compare
The library was luckily approved two days ago https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/3033 |
|
Abandoned in favor of eclipse-theia#11455 |
What it does
Review checklist
Reminder for reviewers
Signed-off-by: Alexandra Buzila abuzila@eclipsesource.com