Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect validationMode in React material table cells #2400

Merged
merged 4 commits into from
Dec 5, 2024
Merged

Respect validationMode in React material table cells #2400

merged 4 commits into from
Dec 5, 2024

Conversation

0mpurdy
Copy link
Contributor

@0mpurdy 0mpurdy commented Nov 29, 2024

Fix #2398

@CLAassistant
Copy link

CLAassistant commented Nov 29, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@netlify Netlify
Copy link

netlify bot commented Nov 29, 2024 •
edited
Loading

✅ Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 0038727
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/67509bc14e02b8000820a868
😎 Deploy Preview https://deploy-preview-2400--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@0mpurdy
Copy link
Contributor Author

0mpurdy commented Nov 29, 2024

Before After
before after

@0mpurdy 0mpurdy force-pushed the validation-mode-cell-2398 branch from 811073d to d8371c2 Compare November 29, 2024 17:29
@sdirix sdirix requested a review from lucas-koehler December 4, 2024 10:37
@lucas-koehler
Copy link
Contributor

@0mpurdy Thanks for the contribution ❤️
The changes already look quite good to me. Please have a look at my answer to your comment #2400 (comment)

@0mpurdy 0mpurdy force-pushed the validation-mode-cell-2398 branch from d8371c2 to 0038727 Compare December 4, 2024 18:13
@coveralls
Copy link

Coverage Status

coverage: 82.089% (-0.001%) from 82.09%
when pulling 0038727 on 0mpurdy:validation-mode-cell-2398
into 5595934 on eclipsesource:master.

lucas-koehler
lucas-koehler approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now! Thanks for the contribution and all the tests ✨

@lucas-koehler lucas-koehler merged commit 4a4e2ec into eclipsesource:master Dec 5, 2024
8 checks passed
@sdirix sdirix changed the title React material table cell validationMode Respect validationMode in React material table cells Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-koehler lucas-koehler lucas-koehler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ValidateAndHide only partially working for react material table cell
4 participants
@0mpurdy @CLAassistant @lucas-koehler @coveralls