Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance example app #1877

Merged
merged 7 commits into from
Apr 7, 2022
Merged

Enhance example app #1877

merged 7 commits into from
Apr 7, 2022

Conversation

TheZoker
Copy link
Contributor

@TheZoker TheZoker commented Jan 25, 2022

Enhance the example app with the following features:

  • Show current uischema (with code highlighting)
  • Show current schema (with code highlighting)
  • Option to show/hide data/schema/uischema panel
  • Allow to link to a certain example
  • Use same example on page reload
  • Enhance example design

Screenshot:
image

@coveralls
Copy link

coveralls commented Jan 25, 2022

Coverage Status

Coverage remained the same at 84.29% when pulling 75a2eb1 on TheZoker:enhance-example into d65d7eb on eclipsesource:master.

Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes! In general I like them very much!

  • Please remove the Example title over the form, it's not needed
  • Can't we just always expand the left schema/uischema/data box? If not, then please replace the expand link with a button
  • I would prefer the form not having a background color

packages/example/src/App.tsx Outdated Show resolved Hide resolved
packages/example/src/App.tsx Outdated Show resolved Hide resolved
packages/example/src/App.tsx Outdated Show resolved Hide resolved
packages/example/src/App.tsx Outdated Show resolved Hide resolved
Co-authored-by: Stefan Dirix <sdirix@eclipsesource.com>
@TheZoker TheZoker requested a review from sdirix February 15, 2022 20:53
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the improvements!

@sdirix sdirix merged commit 7e5ac13 into eclipsesource:master Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants