always reuse AJV instance from store

[DBosley]

This PR changes packages/core/src/util/runtime.ts so it no longer creates an instance of AJV on file load. It will only run createAjv() if an instance of AJV is not supplied to any of the exported utilities. This moves the project closer to full abstraction of AJV to allow it as a peer dependency.

This change will allow users to inject their own instances of AJV and that instance will be used throughout the library. It allows a user to create mocks or delegates for core AJV functions which can be leveraged to void unsafe-eval errors in projects with CSP enabled.

#1498 #1557

[sdirix]

Thanks for this PR!

• We can assume that Ajv will always be in the state as we require that the init action was executed before rendering. Therefore we can just always extract Ajv from the state without creating a new instance when it doesn't exist (as this has already happened if needed in the init action).
• I would also prefer not giving Ajv as a prop to all renderers as no renderer besides MaterialCategorizationLayout and MaterialCategorizationStepperLayout care about it. Instead we could add a withAjv HOC which can be used by any renderer additionally to their withJsonFormsXXXProps HOC, e.g. withAjv(withJsonFormsLayoutProps(MaterialCategorizationLayoutRenderer)).

[DBosley]

Let me know if there's anything I can do to expedite getting this merged in and published to NPM. Once it is, I can begin figuring out ways to avoid usafe-evals with packed AJV modules.

[sdirix]

I removed the remaining default Ajvs and fixed the then failing testcases. Looks good now to me!

[DBosley]

Will this be released to NPM soon, or will this have to wait for a future publish? I made sure the utility functions all had defaults so there would be no breaking changes. I'm hoping it will be possible to publish it as a patch and a not a full major or minor version increment. As I mentioned before, this PR should unblock my work on my own project and let me figure out the details for implementing the packed AJV injector/wrapper.

I don't mean to rush you or your team, I'm just trying to get an estimate so I can relay the info back to my team.

[sdirix]

I made sure the utility functions all had defaults so there would be no breaking changes

There should not be any breaking change here. At least not when only using JsonForms. When reusing code in custom renderers this will be a breaking change but a very easy one to fix.

Will this be released to NPM soon, or will this have to wait for a future publish?

I'm in the progress of releasing the first beta of 2.4.1 which you can then consume. The stable release will probably be in mid to end of September.

[sdirix]

Release is done. You can consume it via @jsonforms/core@next or @jsonforms/core@2.4.1-beta.0 (same for other packages). Thanks again for the contribution!

[DBosley]

Thank you!