Fix field binding #1263
Merged
Fix field binding #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31ed789 to
7335d1f
Compare
eneufeld
requested changes
Feb 17, 2019
| @@ -155,7 +155,7 @@ const NonEmptyCell = ({ | |||
| undefined, | |||
| scopedSchema.type === 'object' ? `#/properties/${propName}` : '#' | |||
| )} | |||
| path={rowPath} | |||
| path={rowPath + (scopedSchema.type === 'object' ? '.' + propName : '')} | |||
There was a problem hiding this comment.
good catch, we should probably fix line 146 accordingly
b212178 to
0c75600
Compare
0c75600 to
a1cf3f6
Compare
eneufeld
approved these changes
Feb 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fields do not alter their own path anymore, hence we need to pass it in accordingly. This should fix the most recent example in #1253