react 17 support

[lukesmurray]

If you try to install json forms with react 17 you get the following error.

npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: my-jsonforms-app@0.1.0
npm ERR! Found: react@17.0.2
npm ERR! node_modules/react
npm ERR!   react@"^17.0.2" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.12.0" from @jsonforms/react@2.5.0
npm ERR! node_modules/@jsonforms/react
npm ERR!   @jsonforms/react@"*" from the root project

I believe this error can be traced to the following line

jsonforms/packages/react/package.json

Line 80 in 9b95669

"react": "^16.12.0"

Is JSON forms actually incompatible with react 17? Is it possible to support both 16 and 17?

[sdirix]

Hi! JSON Forms works perfectly fine with React 17. We'll update the version constraints with the next release.

I'm wondering why this shows up as an error for you. Usually peer dependency issues are presented as warnings.

[lukesmurray]

I’ll try to come up with a simple reproduction and get back to you. You can close for now.

…

On Fri, Apr 23, 2021 at 10:22 AM Stefan Dirix ***@***.***> wrote: Hi! JSON Forms works perfectly fine with React 17. We'll update the version constraints with the next release. I'm wondering why this shows up as an error for you. Usually peer dependency issues are presented as warnings. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1738 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIDRW4SIWYMAL45KXJ3XY33TKF7DJANCNFSM43MSSSXA> .