Skip to content
This repository has been archived by the owner on Jan 15, 2020. It is now read-only.

Fix #148 Improve css styling and fix theming issues #149

Merged
merged 5 commits into from
Jan 28, 2019

Conversation

tortmayr
Copy link
Collaborator

planger
planger previously approved these changes Jan 25, 2019
Copy link
Collaborator

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks a lot!

@tortmayr
Copy link
Collaborator Author

Thanks for the review. I will fix the conflicts.
While we are at it: I noticed that all code reviews get dismissed when new code is pushed to the PR branch. This is also the case for already approved changes. As a consequence we always have to ask for a new review after resolving conflicts or other minor fixes.

@tortmayr
Copy link
Collaborator Author

Apparently this can be disabled (isaacs/github/issues/1157) in:
SettingsBranchesBranch protection rulesEditUncheck "Dismiss stale pull request approvals when new commits are pushed".

Copy link
Collaborator

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@tortmayr tortmayr merged commit 0a01e9c into master Jan 28, 2019
@tortmayr tortmayr deleted the tortmayr/issues/148 branch January 28, 2019 10:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants