control rpm verification flags #6
Conversation
see ctron/rpm-builder#41 Signed-off-by: Oliver Matz <oliver.matz@dataport.de>
rpm/pom.xml
Outdated
| <!-- show log output during tests using log4j as the slfj backend. --> | ||
| <dependency> | ||
| <groupId>org.slf4j</groupId> | ||
| <artifactId>slf4j-log4j12</artifactId> |
There was a problem hiding this comment.
I know, this is just my disliking of log4j … could you use logback instead.
There was a problem hiding this comment.
I really do not care as long as I can somehow manage to see the log output.
There was a problem hiding this comment.
I have switched to https://mvnrepository.com/artifact/ch.qos.logback/logback-classic V 1.2.3 and pushed.
|
This looks good! Thank you. Only a few things of cleaning up. |
| MODE( 1 << 6), // 'M' | ||
| RDEV( 1 << 7), // 'D' | ||
| CAPS( 1 << 8); // 'P' | ||
| // VERIFY_CONTEXTS = (1 << 15), VERIFY_FILES = (1 << 16), VERIFY_DEPS = (1 << 17), |
There was a problem hiding this comment.
Is there a reason for commenting the others out?
There was a problem hiding this comment.
I have not understood the other flags. Besides I had the impression that there is some reason for that gap in the numbering. For my purposes, it really means no difference, so I am open to include those or leave it as it is.
There was a problem hiding this comment.
I think is makes sense to add them all. In the end, this part is only passing them through. So not much processing is done here. For the Maven plugin, it may be a different story.
There was a problem hiding this comment.
O.K., I will comment in those ones and then push
... done
Requires modifications from eclipse/packager#6 Fix for ctron#41. Signed-off-by: Oliver Matz <oliver.matz@dataport.de>
Signed-off-by: Oliver Matz <oliver.matz@dataport.de>
Signed-off-by: Oliver Matz <oliver.matz@dataport.de>
Signed-off-by: Oliver Matz <oliver.matz@dataport.de>
| @@ -0,0 +1,54 @@ | |||
| package org.eclipse.packager.rpm; | |||
There was a problem hiding this comment.
I am sorry I overlooked this before, but this file is missing a license header.
|
|
||
| // The purpose of the following constants is not clear to me. | ||
| // Do they refer to the same bitmask? Oliver Matz | ||
| // see diskussion in https://github.com/eclipse/packager/pull/6 |
There was a problem hiding this comment.
| // see diskussion in https://github.com/eclipse/packager/pull/6 | |
| // see discussion in https://github.com/eclipse/packager/pull/6 |
There was a problem hiding this comment.
oops. fixed + pushed.
| * It should rather be "VerifyFlag" (singular), but I leave it this way, cf. {@link FileFlags}. | ||
| * The constants and their value are from http://ftp.rpm.org/api/4.14.0/group__rpmvf.html | ||
| * @since 0.15.2 | ||
| * @author Oliver Matz |
There was a problem hiding this comment.
The project doesn't use @author tags. If you want your name added somehow, I can understand and we could achieve this using the NOTICE file instead.
Signed-off-by: Oliver Matz <oliver.matz@dataport.de>
Signed-off-by: Oliver Matz <oliver.matz@dataport.de>
* New test EntryDetailsTest * see #42 * EntryDetailsTest: verify return value of EntryDetails.apply(..) * Allow to control verification flags. * Requires modifications from eclipse/packager#6 * Fix for #41. * upgrade org.eclipse.packager:packager-rpm to 0.16.0 * resolve merge conflict * rename VerifyDetails.md5 to fileDigest, add javadoc * add license header * primitive boolean rather than Boolean, * dadaistic javadoc to suppress warnings Signed-off-by: Oliver Matz <oliver.matz@dataport.de>
see ctron/rpm-builder#41
Signed-off-by: Oliver Matz oliver.matz@dataport.de