Merge pull request #1033 from amvanbaren/bugfix/publisher-agreement-u…

…ndefined Always set PublisherAgreement
eclipse · Nov 6, 2024 · ede9ed4 · ede9ed4
2 parents c317d0d + 8ab504e
commit ede9ed4
Showing 1 changed file with 9 additions and 9 deletions.
diff --git a/server/src/main/java/org/eclipse/openvsx/eclipse/EclipseService.java b/server/src/main/java/org/eclipse/openvsx/eclipse/EclipseService.java
@@ -166,24 +166,25 @@ public void enrichUserJson(UserJson json, UserData user) {
         }
 
         var publisherAgreement = new UserJson.PublisherAgreement();
+        publisherAgreement.setStatus("none");
+        json.setPublisherAgreement(publisherAgreement);
+
         var personId = user.getEclipsePersonId();
         if (personId == null) {
-            publisherAgreement.setStatus("none");
             return;
         }
 
         var usableToken = true;
         try {
             // Add information on the publisher agreement
             var agreement = getPublisherAgreement(user);
-            if (agreement == null || !agreement.isActive() || agreement.version() == null)
-                publisherAgreement.setStatus("none");
-            else if (publisherAgreementVersion.equals(agreement.version()))
-                publisherAgreement.setStatus("signed");
-            else
-                publisherAgreement.setStatus("outdated");
-            if (agreement != null && agreement.timestamp() != null)
+            if(agreement != null && agreement.isActive() && agreement.version() != null) {
+                var status = publisherAgreementVersion.equals(agreement.version()) ? "signed" : "outdated";
+                publisherAgreement.setStatus(status);
+            }
+            if (agreement != null && agreement.timestamp() != null) {
                 publisherAgreement.setTimestamp(TimeUtil.toUTCString(agreement.timestamp()));
+            }
         } catch (ErrorResultException e) {
             if(e.getStatus() == HttpStatus.FORBIDDEN) {
                 usableToken = false;
@@ -192,7 +193,6 @@ else if (publisherAgreementVersion.equals(agreement.version()))
             }
         }
 
-        json.setPublisherAgreement(publisherAgreement);
         // Report user as logged in only if there is a usable token:
         // we need the token to access the Eclipse REST API
         if(usableToken) {