Remove usage of jackson type reference where it is not needed #5465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d6bc789 to
12f7be4
Compare
12f7be4 to
f110635
Compare
Motivation: Jackson's TypeReference is only supported by the DatabindCodec. A few methods declaring TypeReference are still available on JacksonCodec and JsonEvent, such methods should be removed because the lead to incomplete usage of JacksonCodec and will simply not work at all with potential other implementations of the JSON spi. Changes: Remove methods declaring TypeReference and update tests accordingly.
f110635 to
340492e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove usage of Jackson
TypeReference.Motivation:
Jackson's
TypeReferenceis only supported by theDatabindCodec. A few methods declaringTypeReferenceare still available onJacksonCodecandJsonEvent, such methods should be removed because the lead to incomplete usage ofJacksonCodecand will simply not work at all with potential other implementations of the JSON spi.Changes:
Remove methods declaring
TypeReferenceand update tests accordingly.